Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] remove empty parenthesis on id #1154

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

jrushlow
Copy link
Collaborator

To be consistent with other empty columns generated by maker.

e.g.

    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\Column()]    // () is not needed
    private ?int $id = null;

    #[ORM\Column(length: 255)]
    private ?string $name = null;

    #[ORM\Column]
    private ?int $price = null;

@jrushlow jrushlow added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Jul 20, 2022
@jrushlow jrushlow merged commit 28319be into symfony:main Jul 21, 2022
@jrushlow jrushlow deleted the fix/empty-attribute branch July 21, 2022 19:30
@jrushlow jrushlow mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants