[make:security:form-login] new maker to use built in FormLogin #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
changed the title
jrushlow
added
Status: Needs Review
jrushlow
commented
Nov 29, 2022
weaverryan
reviewed
Nov 29, 2022
|
|
||
| $form->setValues([ | ||
| '_username' => 'jr@rushlow.dev', | ||
| '_password' => 'badPass', |
There was a problem hiding this comment.
I misread this originally. I thought you were logging in as jr@rushlow.dev, password badass 😆
Co-authored-by: Ryan Weaver <weaverryan+github@gmail.com>
Co-authored-by: Ryan Weaver <weaverryan+github@gmail.com>
weaverryan
approved these changes
Nov 29, 2022
|
|
||
| /** | ||
| * @legacy This can be removed once we deprecate/remove `make:auth` | ||
| */ |
There was a problem hiding this comment.
I think that's not technically true. It's just that once we remove make:auth, this won't NEED to be in a private method anymore. I'd remove this.
There was a problem hiding this comment.
The private method shouldn't be needed anymore here. We have a public updateForLogout() that this logic will be moved to.
jrushlow
added
Status: Reviewed
Merged
weaverryan
added a commit
that referenced
this pull request
Jun 7, 2023
This PR was merged into the 1.0-dev branch. Discussion ---------- [git-released] v1.49.0 # Changelog ## [v1.49.0](https://github.com/symfony/maker-bundle/releases/tag/v1.49.0) *Jun 7th, 2023* ### Feature - [#1321](#1321) - Changing make:stimulus-controller to require StimulusBundle - *`@weaverryan`* - [#1309](#1309) - Apply `get_class_to_class_keyword` PHP-CS-Fixer rule - *`@seb`-jean* - [#1276](#1276) - [make:migration] Change message when required package for migration doesn't exist. - *`@bdaler`* - [#1261](#1261) - [make:registration-form] use UniqueEntity attribute instead of annotation - *`@jrushlow`* - [#1253](#1253) - [make:migration] Add link to new migration files - *`@nicolas`-grekas* - [#1251](#1251) - [make:*] use php-cs-fixer to style/lint all generated php templates - *`@jrushlow`* - [#1244](#1244) - [make:security:form-login] new maker to use built in FormLogin - *`@jrushlow`* - [#1242](#1242) - [make:*] use static return type instead of self for setters - *`@jrushlow`* - [#1239](#1239) - Improve error messages to show PHP & XML configurations are not supported - *`@ThomasLandauer`* - [#1238](#1238) - [make:*] improve output messages for Symfony CLI users - *`@jrushlow`* - [#1237](#1237) - [make:registration-form] Print registration form errors - *`@comxd`* ### Bug - [#1307](#1307) - [make:twig-component] handle upstream changes to how live components are rendered - *`@jrushlow`* - [#1270](#1270) - [make:authenticator] Core\Security or SecurityBundle\Security - Avoid deprecations in 6.2 - *`@nacorp`* - [#1265](#1265) - [make:crud] Make sensio/framework-extra-bundle an optional dependency - *`@acrobat`* - [#1264](#1264) - [make:controller] doctrine/annotations is not needed - *`@jrushlow`* - [#1262](#1262) - [make:reset-password] doctrine/annotations are not needed - *`@jrushlow`* _Generated by Git Released_ Commits ------- a7bb5c6 Updating date, adding 1 more PR cb06c33 [release] v1.49.0
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 23, 2024
…le in MakerBundle (jrushlow) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Security] WIP - make:security:form-login is now available in MakerBundle MakerBundle is going to introduce a new command to generate and configure the files needed for `FormLogin` in SecurityBundle. Not sure if we should completely remove the "manual" howto in the docs or go with something like I have here. Note: Command name and output subject to change until we merge, I'll update this PR accordingly. In the meantime, feedback welcomed! Note: Additional `make:security:*` commands to follow shortly. ## Blockers: - [x] Merge symfony/maker-bundle#1244 - [ ] Release MakerBundle `1.49.0` Commits ------- a6b2fd0 [Security] WIP - make:security:form-login is now available in MakerBundle
|
@jrushlow I've just updated the book, so it will use the new command in the 6.4 version of the book, to be released soon. Thank you for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new series of makers that use the built-in
SecurityBundleauthenticators. The first -make:security:form-loginwith the next probably beingmake:security:json-login? which will abstract any common functionality thatmake:security:*can re-use...This PR does not deprecate
make:authyet. Once we have amake:security:custom-authenticatorin place - we can sunsetmake:auth.fixes #1049
@wouterj - Im going to steal some of the concepts/code from #1058 so we can implement that PR in baby steps - starting with FormLogin