Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relations to entity form generation #1373

Conversation

maelanleborgne
Copy link
Contributor

@maelanleborgne maelanleborgne commented Oct 13, 2023

PR for #1372

When generating a form for an entity (through make:form or make:crud), this feature adds an EntityType input for each compatible relations in the generate form.

  • Add tests

@maelanleborgne maelanleborgne force-pushed the feature/add-relation-in-form-generation branch 2 times, most recently from 3ab1276 to df282f4 Compare October 13, 2023 15:36
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me - I'd love to see a test and also the multiple => true when needed

@weaverryan weaverryan force-pushed the feature/add-relation-in-form-generation branch from aeac1cc to 85e4306 Compare October 31, 2023 18:23
@weaverryan
Copy link
Member

Thanks @maelanleborgne!

@weaverryan weaverryan merged commit 112f946 into symfony:main Oct 31, 2023
5 of 6 checks passed
@maelanleborgne maelanleborgne deleted the feature/add-relation-in-form-generation branch April 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants