Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] use ux-turbo instead of ux-turbo-mercure #1445

Merged
merged 1 commit into from Feb 20, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 8, 2024

No description provided.

@jrushlow jrushlow added the Bug Bug Fix label Feb 8, 2024
@jrushlow jrushlow changed the title [make:entity] stop using ux-turbo-mercure [make:entity] use ux-turbo instead of ux-turbo-mercure Feb 8, 2024
@jrushlow jrushlow force-pushed the feature/use-ux-turbo branch 3 times, most recently from 204a62e to 4f3452f Compare February 15, 2024 14:43
@jrushlow jrushlow marked this pull request as ready for review February 15, 2024 14:43
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Feb 15, 2024
@@ -0,0 +1,12 @@
services:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for local dev's to be able to run mercure tests

})
->addExtraDependencies('mercure', 'twig')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ux-turbo installs stimulus-bundle which requires twig. But the twig recipe doesn't get generated in the tmp/cache project. adding it as an extra depend fixes that.

mercure is needed obviously to pub/sub changes

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 20, 2024
@jrushlow jrushlow merged commit d443032 into symfony:main Feb 20, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/use-ux-turbo branch February 20, 2024 16:56
@jrushlow jrushlow mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants