[make:entity] only show supported types in cli wizard #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
ci/make-entity-legacy-test
branch
from
5e4ed0f
to
b82d78c
Compare
jrushlow
changed the title
jrushlow
commented
Feb 14, 2024
| // get the dependencies installed in the test project (tmp/cache/TEST) | ||
| $installedVersions = require $runner->getPath('vendor/composer/installed.php'); | ||
|
|
||
| if (!str_starts_with($installedVersions['versions']['doctrine/dbal']['version'], '3.')) { |
There was a problem hiding this comment.
hack way to determine if dbal 3 or 4 is installed. MakerTestRunner::doesClassExist() doesnt provide all available classes for a cached project under test. To be dealt with under a different PR.
jrushlow
commented
Feb 14, 2024
| @@ -490,11 +488,30 @@ private function printAvailableTypes(ConsoleStyle $io): void | |||
| $io->writeln(''); | |||
| }; | |||
|
|
|||
| $printRelationsSection = static function () use ($io) { | |||
There was a problem hiding this comment.
broke out handling relations to reduce the complexity above. otherwise we're nesting if's 3+ layers deep.
weaverryan
approved these changes
Feb 14, 2024
jrushlow
added
Status: Reviewed
This was referenced Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
make:entityfield type question when passing?to see all available types.ascii_stringas an "or" type forstringallows for removed types in DBAL 4 to still be available for users on DBAL 3
fixes #1446