Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - failing generator test with global ns collision #1482

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/GeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

$classNameDetails = $generator->createClassNameDetails($name, $prefix, $suffix);

$this->assertSame($expectedFullClassName, $classNameDetails->getFullName());

Check failure on line 34 in tests/GeneratorTest.php

View workflow job for this annotation

GitHub Actions / PHP 8.2 + @6.4.x-dev highest deps

Failed asserting that two strings are identical.

Check failure on line 34 in tests/GeneratorTest.php

View workflow job for this annotation

GitHub Actions / PHP 8.2 + @7.0.x-dev highest deps

Failed asserting that two strings are identical.

Check failure on line 34 in tests/GeneratorTest.php

View workflow job for this annotation

GitHub Actions / PHP 8.1 + @6.4.* lowest deps

Failed asserting that two strings are identical.

Check failure on line 34 in tests/GeneratorTest.php

View workflow job for this annotation

GitHub Actions / PHP 8.1 + @6.4.* highest deps

Failed asserting that two strings are identical.
$this->assertSame($expectedRelativeClassName, $classNameDetails->getRelativeName());
}

Expand Down Expand Up @@ -100,5 +100,13 @@
'Symfony\\Bundle\\MakerBundle\\Tests\\GeneratorTest',
'Symfony\\Bundle\\MakerBundle\\Tests\\GeneratorTest',
];

yield 'class_with_global_ns_collision' => [
'Locale',
'\\Entity',
'',
'App\\Entity\\Locale',
'Locale',
];
}
}