Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] Fix exception message if mercure bundle not found with --broadcast #1486

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

cavasinf
Copy link
Contributor

Error says symfony/mercure but the class_exist looks for Symfony\Bundle\MercureBundle\DependencyInjection\MercureExtension.
Switch to symfony/mercure-bundle instead.

@jrushlow jrushlow added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Mar 22, 2024
@jrushlow jrushlow changed the title [MakeEntity] Fix RuntimeCommandException message [make:entity] Fix exception message if mercure bundle not found with --broadcast Mar 22, 2024
@jrushlow jrushlow mentioned this pull request Mar 22, 2024
@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 22, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this @cavasinf

@jrushlow jrushlow merged commit 39926b8 into symfony:main Mar 22, 2024
6 checks passed
@cavasinf cavasinf deleted the patch-1 branch March 22, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants