[make:security] Add throttling support to authenticator maker #1524
+72
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
enhanced-auth
branch
3 times, most recently
from
3897b2d
to
239554d
Compare
In the MakeAuthenticator class, a new optional argument 'support-throttling' was added. This allows the user to specify if they want to enable throttling protection during the authentication generation process. If 'support-throttling' is enabled, the LimiterInterface dependency is added and the 'throttling' node is set in the firewall configuration.
jrushlow
reviewed
Apr 26, 2024
| @@ -209,6 +210,15 @@ function ($answer) { | |||
| $supportRememberMeValues[$supportRememberMeType] | |||
| ); | |||
| } | |||
|
|
|||
| $command->addArgument('support-throttling', InputArgument::OPTIONAL); | |||
There was a problem hiding this comment.
MakeAuthenticator is being deprecated - we are not adding any new features to it.
jrushlow
requested changes
Apr 26, 2024
jrushlow
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Howdy @Spomky - Sorry for the double review... Coffee has not kicked in yet...
Anywho, as I said in #1406 (comment) make:auth is being deprecated in favor of the make:security:form-login command. We are not adding any new features to make:auth at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #1406
In the MakeAuthenticator class, a new optional argument 'support-throttling' was added. This allows the user to specify if they want to enable throttling protection during the authentication generation process. If 'support-throttling' is enabled, the LimiterInterface dependency is added and the 'throttling' node is set in the firewall configuration.