Allow Symfony 5 + many cleanups #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
sf5
branch
3 times, most recently
from
f11b20d
to
2e10914
Compare
weaverryan
reviewed
Oct 20, 2019
| $this->fs->symlink('../../../../../../vendor/symfony/phpunit-bridge', './vendor/symfony/phpunit-bridge'); | ||
| } else { | ||
| $this->fs->mirror(\dirname(__DIR__, 2).'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge'); | ||
| } |
There was a problem hiding this comment.
Using the required phpunit bridge was now a problem?
There was a problem hiding this comment.
The bridge used for the main test suite and for functional tests must be at exactly the same version because they share the same runtime space. This leads to a fatal error right now when main is 4.4 or 5.0 but functionals stay at 4.3.
| ), | ||
| $this->createNullConstant(), | ||
| new Node\Expr\Variable('this') | ||
| ) | ||
| )) | ||
| ); | ||
|
|
||
| // if ($newUserProfile !== $user->getUserProfile()) { |
There was a problem hiding this comment.
What prompted needing to flip all of these?
There was a problem hiding this comment.
Running php-cs-fixer
|
Thanks Nicolas! |
weaverryan
added a commit
that referenced
this pull request
Oct 21, 2019
This PR was merged into the 1.0-dev branch. Discussion ---------- Allow Symfony 5 + many cleanups Note that having php-cs-fixer in the deps blocks installing Symfony 5 (did I already mention it's a bad practice to add tools as deps? ;) ) But locally when I remove php-cs-fixer (and patch the code to use my local version), all is green, with SF5 deps. Commits ------- 2cf9460 Allow Symfony 5 + many cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that having php-cs-fixer in the deps blocks installing Symfony 5 (did I already mention it's a bad practice to add tools as deps? ;) )
But locally when I remove php-cs-fixer (and patch the code to use my local version), all is green, with SF5 deps.