Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to create Custom Skeleton Dir #520

Closed
wants to merge 2 commits into from
Closed

Allow user to create Custom Skeleton Dir #520

wants to merge 2 commits into from

Conversation

MagnusDot
Copy link

@MagnusDot MagnusDot commented Dec 16, 2019

This is linked to the issue #33

@sadikoff
Copy link
Contributor

I totally disagree with such changes! It should be implemented in another way, to allow changing all skeleton templates.

I'll advise opening an issue about it, and start a discussion to find out how it should be implemented or even should it be implemented or no.

@MagnusDot
Copy link
Author

I totally disagree with such changes! It should be implemented in another way, to allow changing all skeleton templates.

I'll advise opening an issue about it, and start a discussion to find out how it should be implemented or even should it be implemented or no.

An issue is already opened #33

@sadikoff
Copy link
Contributor

sadikoff commented Dec 16, 2019

@MagnusDot Whoops missed it, thanks for the link!

But it doesn't change my opinion on it. I think it shouldn't be implemented only for the CRUD generator. However, I like the ability to have my own skeleton files 😄

@MagnusDot
Copy link
Author

Owever for the moment nobody done the possibility to have our own skeleton files,
I propose my solution but if someone wants to do it in another way, free to him

@johnpancoast
Copy link

Not to knock anyone's work, but for what it's worth, I don't think allowing devs to change the directory is the best approach. See my new comment. I think this is/was a perfect use case for Twig.

@weaverryan weaverryan changed the base branch from master to main November 16, 2020 20:02
@jrushlow jrushlow added the Feature New Feature label May 10, 2022
@jrushlow
Copy link
Collaborator

jrushlow commented Mar 4, 2024

Thanks for the PR, but I'm going to close this - I do not think this is the direction we should go. Yes, it would be nice to be able to override the templates we have in MakerBundle for something like make:crud. However, in doing so, I'm worried it would increase our maintenance burden. By shifting that responsibility to the consumers of MakerBundle - via the usage AbstractMaker - we can keep focusing on iterating over new features/fixes instead of working around potential BC to support customizable templates.

@jrushlow jrushlow closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants