Dropping doctrine/inflector v2 support temporarily #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
drop-inflector-v2
branch
from
0ea070d
to
e75a956
Compare
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2020
This PR was merged into the 1.0-dev branch. Discussion ---------- reinstate doctrine/inflector v2 support due to incompatibilities with `doctrine/orm`, `doctrine/inflector` `v2` was dropped in #611. `orm` now supports inflector v2 as of doctrine/orm#8147 which has been released. closes #756 Commits ------- 0e8c486 reinstate doctrine/inflector v2 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causting doctrine/inflector v2 to be installed. Then,
if a user required another package that only worked with v1 - like
doctrine/orm, that package would fail to install because the user's
app is locked on v2.
Dropping support for v2 isn't really a fix, but will make it more
compatible with the ecosystem at the current time. Later, especially
when doctrine/orm allows 2, we can again.
See also composer/composer#8910
Note: I kept the v2 compatible code in the bundle for now.
Fixes #609