[ResetPassword & VerifyEmail] fix templated email "lifetime" being mutated by timezones #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the twig email templates, the
This link will expire in 1 hour(s).
is malformed if a timezone is set either in twig or in PHP.In the controllers of both ResetPassword & VerifyEmail(RegistrationController) the token lifetime is expressed as
int X
. The lifetime is then passed to the twig templated email where it is ultimately passed to thedate
filter. This PR enforces that the lifetime value should always be formatted in the UTC timezone.This is only a temporary solution. Ideally, either the
ResetPasswordBundle
&VerifyEmailBundle
orMakerBundle
should use a math based method to transform the lifetime value to a human readable format. e.gRefs SymfonyCasts/reset-password-bundle#119