Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to smsapi-notifier #4

Closed
wants to merge 1 commit into from

Conversation

szepczynski
Copy link
Contributor

Hi,

I created integration to notifier to support polish operators with smsapi.pl service.

smsapi-notifier is here: https://github.com/szepczynski/smsapi-notifier

I've tested integration by using this version of framework-bundle:
https://github.com/szepczynski/framework-bundle

and symfony-notifier in this PR

Can you add support of smsapi-notfier to symfony/symfony-notifier and symfony/framework-bundle?

@symfony-bot
Copy link

symfony-bot bot commented May 23, 2020

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this May 23, 2020
@szepczynski
Copy link
Contributor Author

Hi @nicolas-grekas,

The symfony/symfony doesn't includes symfony/notifier component itself. It's only exists as a dependency of symfony/symfony. In which way should I provide a PR to symfony/notifier?

I've created integration to notifier to support polish sms operator - smsapi.pl

Here is smsapi-notifier integration: https://github.com/szepczynski/smsapi-notifier
Here are changes in notifier repository including smsapi-notifier: https://github.com/szepczynski/notifier
Here are changes in framework-bundle repository including smsapi-notifier: https://github.com/szepczynski/framework-bundle
Could someone integrate this into notifier component?

@fabpot
Copy link
Member

fabpot commented May 24, 2020

All the work is done in symfony/symfony, which is then split into several read-only repositories like this one.

@szepczynski
Copy link
Contributor Author

szepczynski commented May 24, 2020

Thanks for the reply; I click on Fork in symfony/symfony repo, but didn't notice that repo wasn't a fresh fork because I forked them in the past.

When I clone repo local I can't find on master Notifier component and I didn't know how to make a PR on symfony/symfony if this component does not exists :)

Here is PR: symfony/symfony#36940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants