Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass timeout options to RemoteWebDriver #259

Merged
merged 1 commit into from Jan 17, 2020
Merged

Pass timeout options to RemoteWebDriver #259

merged 1 commit into from Jan 17, 2020

Conversation

metaer
Copy link
Contributor

@metaer metaer commented Nov 7, 2019 •
edited

Allows to set timeouts like this:

$client = Client::createChromeClient(null, [], [
    'connection_timeout_in_ms' => 5000,
    'request_timeout_in_ms' => 120000,
]);

Partially fixes #155 (one case)

@metaer
Copy link
Contributor Author

metaer commented Nov 12, 2019 •
edited

Do we need something else for merge PR? @dunglas

@rocramer
Copy link
Contributor

Are there plans to merge this PR soon?

@metaer
Copy link
Contributor Author

metaer commented Jan 16, 2020

Are there plans to merge this PR soon?

May be @chalasr knows

chalasr
chalasr approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We will merge and release as soon as we have time.

@dunglas dunglas merged commit 2248362 into symfony:master Jan 17, 2020
@dunglas
Copy link
Member

dunglas commented Jan 17, 2020

Sorry for the delay thanks @metaer

@metaer metaer deleted the timeout_options branch January 17, 2020 11:04
@rocramer rocramer mentioned this pull request Jan 20, 2020
Merged
dunglas added a commit that referenced this pull request Dec 28, 2020
@dunglas
Merge pull request #259 from metaer/timeout_options
ff74beb 
Pass timeout options to RemoteWebDriver
nicolas-grekas pushed a commit that referenced this pull request Jan 18, 2021
@dunglas
Merge pull request #259 from metaer/timeout_options
bd544f4 
Pass timeout options to RemoteWebDriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webdriver curl exception
4 participants
@metaer @rocramer @dunglas @chalasr