Pass timeouts to RemoteWebDriver (Selenium) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 21, 2020
dunglas
approved these changes
Jan 21, 2020
|
Thanks @rocramer |
dunglas
pushed a commit
that referenced
this pull request
Dec 28, 2020
* Add timeouts to SeleniumManager * Create php.yml * Update php.yml * Update php.yml * Remove accidentally committed file.
nicolas-grekas
pushed a commit
that referenced
this pull request
Jan 18, 2021
* Add timeouts to SeleniumManager * Create php.yml * Update php.yml * Update php.yml * Remove accidentally committed file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #259 that got merged today introduced the possibility to add timeouts to the RemoteWebDriver. Unfortunately only for the standalone chrome browser. This PR adds the timeout parameter for selenium as well.