php54 polyfill hex2bin(): don't return false if nul bytes found #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is the expected behaviour, we will at least need a test to prevent regressions. |
|
@xabbuh Test added. |
|
I suspect that this is a rather big issue on older systems using Symfony. The current implementation apparently does not correctly convert hex strings with null bytes. I'd really love to see this in the next release. Thanks! |
| @@ -33,10 +33,6 @@ public static function hex2bin($data) | |||
|
|
|||
| $data = pack('H*', $data); | |||
There was a problem hiding this comment.
No need for the $data intermediate step. Can you return directly please?
Merged
|
@fuhry In the interest of time, I took the liberty of making the requested changes in #49 -- I hope that's alright. @nicolas-grekas Looks alright now? See #49 |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 29, 2016
This PR was merged into the 1.1-dev branch. Discussion ---------- Fix hex2bin return null Fixes the hex2bin implementation as per #47/#48. This supersedes #48. Commits ------- 7d2358d Removed reference to issue/pull d48b373 Code review changes, fix tests e66be8c polyfill php54: add test for nul byte handling ddfa268 php54 polyfill hex2bin(): don't return false if nul bytes found
|
Thank you @fuhry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47