Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for the facile-it/MongoDB-Bundle #259

Merged
4 commits merged into from
May 18, 2018
Merged

Add recipe for the facile-it/MongoDB-Bundle #259

4 commits merged into from
May 18, 2018

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jan 19, 2018

Q A
License MIT

This adds the recipe for https://github.com/facile-it/mongodb-bundle/

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

"Facile\\MongoDbBundle\\FacileMongoDbBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '}' looking for beginning of object key string

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Jean85
Copy link
Contributor Author

Jean85 commented Jan 19, 2018

The CI build will not pass without the ext-mongodb extension. How can I fix it?

@Nyholm
Copy link
Member

Nyholm commented Jan 21, 2018

Thank you for this PR.

Do not worry too much about travis. It is just a check that things does not blow up... (Maybe we should tell composer to ignore system requirements??)

I ran this recipe manually and I found a small issue.

screen shot 2018-01-21 at 10 37 06

@Jean85
Copy link
Contributor Author

Jean85 commented Jan 21, 2018

Thanks @Nyholm, but ignoring requirements could lead to issues anyway.

Thanks for spotting that; it's the kind of stuff that the Travis build should detect..

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Nyholm
Copy link
Member

Nyholm commented Jan 28, 2018

I still get the same error. Does it work when you try it on a new project?

@Jean85
Copy link
Contributor Author

Jean85 commented Jan 29, 2018

I just installed a fresh Symfony 4 skeleton to try this out and I didn't get the same error:

[EDIT] I just realized that I don't know how to tell Flex to use my fork to test this recipe. How do you do it?

Also, your error should be fixed by my last commit: 66437a5

@Nyholm
Copy link
Member

Nyholm commented Feb 25, 2018

See the steps here to tell flex to use your fork:
https://symfony.sh/r/github.com/symfony/recipes-contrib/259

@Jean85
Copy link
Contributor Author

Jean85 commented Feb 27, 2018

I created an empty Flex project and followed your instructions, and it worked at the first try:

$ composer req "facile-it/mongodb-bundle:^0.6"
Warning: Using https://symfony.sh/r/github.com/symfony/recipes-contrib/259 as the Symfony endpoint
./composer.json has been updated
Warning: Using https://symfony.sh/r/github.com/symfony/recipes-contrib/259 as the Symfony endpoint
Loading composer repositories with package information
Updating dependencies (including require-dev)

Prefetching 2 packages 🎶
  - Downloading (100%)

Package operations: 18 installs, 0 updates, 0 removals
  - Installing symfony/routing (v4.0.4): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.7.0): Loading from cache
  - Installing symfony/http-foundation (v4.0.4): Loading from cache
  - Installing symfony/event-dispatcher (v4.0.4): Loading from cache
  - Installing psr/log (1.0.2): Loading from cache
  - Installing symfony/debug (v4.0.4): Loading from cache
  - Installing symfony/http-kernel (v4.0.4): Loading from cache
  - Installing symfony/finder (v4.0.4): Loading from cache
  - Installing symfony/filesystem (v4.0.4): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/dependency-injection (v4.0.4): Loading from cache
  - Installing symfony/config (v4.0.4): Loading from cache
  - Installing psr/simple-cache (1.0.0): Loading from cache
  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/cache (v4.0.4): Loading from cache
  - Installing symfony/framework-bundle (v4.0.4): Loading from cache
  - Installing mongodb/mongodb (1.2.0): Loading from cache
  - Installing facile-it/mongodb-bundle (0.6.5): Loading from cache
Writing lock file
Generating autoload files
Symfony operations: 3 recipes (262f8a773dad76ae54828602c6cd0176)
  - Configuring symfony/framework-bundle (>=3.3): From github.com/symfony/recipes:master
  - Configuring symfony/routing (>=4.0): From github.com/symfony/recipes:master
  - Configuring facile-it/mongodb-bundle (>=0.6): From github.com/symfony/recipes-contrib:259

I obviously installed the ext-mongodb first, but still, no issues.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks

@ghost ghost merged commit 66437a5 into symfony:master May 18, 2018
ghost pushed a commit that referenced this pull request May 18, 2018
@Jean85 Jean85 deleted the add-mongodb-bundle branch May 18, 2018 12:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants