Liform Bundle #442
Liform Bundle #442
Conversation
GuiEloiSantos
commented
Jul 31, 2018
•
GuiEloiSantos
commented
| Q | A |
|---|---|
| License | MIT |
|
I think I'm facing the same scenario encountered at #163 |
|
Thank you. I do not see that this is similar to #163. Your bundle follows the best practice file structure with means that Flex can install it without a recipe. |
|
@Nyholm you sure? it composer has type: library And even in it readme file is instructing the users to include it on app/AppKernel.php . |
|
Im sure. Also, why does it have type: library? That should be changed since it clearly is a bundle, right? |
|
@Nyholm it should, I'm not a maintainer of this bundle though, and I thought I could use recipes so I don't have to include the bundle manually every time I install it. |
| "env": { | ||
| "TEST_ENV_BOWLS": "test" | ||
| } | ||
| } |
| "all" | ||
| ] | ||
| }, | ||
| "aliases": [ |
There was a problem hiding this comment.
Aliases not supported in the contrib repository
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "bundles": { | |||
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| { | ||
| "bundles": { | ||
| "Limenius\\LiformBundle\\LimeniusLiformBundle": [ | ||
| "all" |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| "Limenius\\LiformBundle\\LimeniusLiformBundle": [ | ||
| "all" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| "all" | ||
| ] | ||
| }, | ||
| "aliases": [ |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| }, | ||
| "aliases": [ | ||
| "liform-recipes" | ||
| ], |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| "aliases": [ | ||
| "liform-recipes" | ||
| ], | ||
| "env": { |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| ], | ||
| "env": { | ||
| "TEST_ENV_BOWLS": "test" | ||
| } |
There was a problem hiding this comment.
Indendation must be a multiple of 4 blanks
| "aliases": [ | ||
| "liform-recipes" | ||
| ] | ||
| } |
| "all" | ||
| ] | ||
| }, | ||
| "aliases": [ |
There was a problem hiding this comment.
Aliases not supported in the contrib repository
|
@GuiEloiSantos you should submit a PR on the limenius/liform-bundle repository for switch the type "library" into "symfony-bundle". Like that the bundle will be compatible with Symfony |
|
And BTW, the section aliases is only for the official recipes |
|
@symfony-flex-server review please |
| "aliases": [ | ||
| "liform-recipes" | ||
| ] | ||
| } |
| "all" | ||
| ] | ||
| }, | ||
| "aliases": [ |
There was a problem hiding this comment.
Aliases not supported in the contrib repository
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "bundles": { | |||
| "Limenius\\LiformBundle\\LimeniusLiformBundle": [ | |||
| "all" | ||
| ] | ||
| }, | ||
| "aliases": [ |
