Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deamon-logger-extra-bundle recipe #549

Merged
2 commits merged into from
Feb 8, 2019

Conversation

Deamon
Copy link
Contributor

@Deamon Deamon commented Oct 26, 2018

Add manifest for logger extra bundle

Q A
License MIT

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

# the handler to update
handlers: 'main'
# configuration for all optionnal fields
config: ~
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with a newline

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Deamon Deamon force-pushed the feat-add-deamon-logger-bundle branch from 77b51bf to e84e642 Compare October 26, 2018 16:58
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@Deamon Deamon changed the title WIP: Add deamon-logger-extra-bundle recipe Add deamon-logger-extra-bundle recipe Oct 29, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Deamon
Copy link
Contributor Author

Deamon commented Nov 2, 2018

Well, I do not intent to provide a recipe for version previous to 4.0 so the travis failed job isn't relevant.

Is it an obligation to do a 3.4 recipe ?

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

No, there is not a requirement for 3.4. It is more of a suggestion.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Deamon
Copy link
Contributor Author

Deamon commented Nov 21, 2018

thank you for your answer @Nyholm, I fixed your feedback today.

@Deamon
Copy link
Contributor Author

Deamon commented Feb 8, 2019

Hi @Nyholm, is it ok for you now ?

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the ping.

@ghost ghost merged commit 623d91e into symfony:master Feb 8, 2019
ghost pushed a commit that referenced this pull request Feb 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants