Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore /bin/.phpunit #282

Merged
1 commit merged into from
Nov 30, 2017
Merged

gitignore /bin/.phpunit #282

1 commit merged into from
Nov 30, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@@ -5,6 +5,7 @@
"tests/": "tests/"
},
"gitignore": [
".phpunit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be /bin/.phpunit instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't account for %BIN_DIR%, while this does

@ghost ghost merged commit 93a5aba into symfony:master Nov 30, 2017
ghost pushed a commit that referenced this pull request Nov 30, 2017
@nicolas-grekas nicolas-grekas deleted the gitignore-phpunit branch November 30, 2017 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants