enable HTML5 e-mail validation #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Dec 22, 2017
symfony/validator/4.1/manifest.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "copy-from-recipe": { | |||
| "config/": "%CONFIG_DIR%/", | |||
There was a problem hiding this comment.
invalid character '}' looking for beginning of object key string
|
There's just one problem here: We not only need the Validator component 4.1, but the FrameworkBundle must be 4.1 or higher too. Should we solve this conflict by adding a PHP config instead which enables this based on the FrameworkBundle version? |
xabbuh
force-pushed
the
symfony-25478
branch
from
6a1ee89
to
420e4c1
Compare
ghost
deployed
to
|
I think the more predictable way is to throw an exception if one uses this config with FrameworkBundle 4.0 |
nicolas-grekas
approved these changes
Jul 24, 2018
fabpot
approved these changes
Jul 27, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#25478 (comment)