Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PHPUnit env to server #561

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@fabpot
Copy link
Member

commented Apr 1, 2019

Q A
License MIT

/cc @nicolas-grekas

@symfony-flex-server
Copy link
Contributor

left a comment

Pull request passes validation.

@fabpot

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Needed as we are checking $_SERVER first in Symfony. So, using $_ENV here means that we can be in a situation where $_SERVER has been set first to dev and the PHPUnit sets $_ENV to test but it has no effect.

@chalasr

chalasr approved these changes Apr 1, 2019

@symfony-flex-server symfony-flex-server bot merged commit defdbd7 into master Apr 1, 2019

1 check passed

continuous-integration/symfony/pr Done
Details

symfony-flex-server bot added a commit that referenced this pull request Apr 1, 2019

@chalasr chalasr deleted the env-vs-server branch Apr 1, 2019

fabpot added a commit to symfony/symfony that referenced this pull request Apr 24, 2019

bug #31210 [PhpUnitBridge] fix reading phpunit.xml on bootstrap (nico…
…las-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[PhpUnitBridge] fix reading phpunit.xml on bootstrap

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Matches symfony/recipes#561

Commits
-------

1d55f80 [PhpUnitBridge] fix reading phpunit.xml on bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.