move environment variable resolving to simple-phpunit script #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
IonBazan
commented
Apr 23, 2019
| @@ -11,6 +11,8 @@ | |||
| <ini name="error_reporting" value="-1" /> | |||
| <server name="APP_ENV" value="test" force="true" /> | |||
| <server name="SHELL_VERBOSITY" value="-1" /> | |||
| <server name="SYMFONY_PHPUNIT_VERSION" value="6.5" /> | |||
There was a problem hiding this comment.
@fabpot @nicolas-grekas I am not really sure if we should use server or env node here.
|
Damn, I just submitted #579 :) |
|
@nicolas-grekas You are right - 3.3 should not be affected by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #561 by moving all the environment variable resolving to
simple-phpunitscript fromsymfony/phpunit-bridgepackage. This allows users to specify PHPUnit version inphpunit.xml.distfile, without actually setting the env variable.