Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation free 5.1 security config #778

Merged
1 commit merged into from
Jun 1, 2020
Merged

Deprecation free 5.1 security config #778

1 commit merged into from
Jun 1, 2020

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 31, 2020

Q A
License MIT
Doc issue/PR -

Following symfony/symfony#36574

ghost
ghost approved these changes May 31, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

yceruto
yceruto commented May 31, 2020
View reviewed changes
symfony/security-bundle/5.1/config/packages/security.yaml
security: false
main:
anonymous: true
lazy: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

main:
-    anonymous: lazy

@nicolas-grekas
Copy link
Member

Can't we do this on 4.4?

@yceruto
Copy link
Member Author

yceruto commented Jun 1, 2020

Can't we do this on 4.4?

The lazy option under the firewall key does not exist on 4.4.

See line ref: https://github.com/symfony/symfony/pull/36574/files#diff-bf3f57964397432b3aa16d5f3be0511aR200

@ghost ghost merged commit ce6d359 into symfony:master Jun 1, 2020
@yceruto yceruto mentioned this pull request Jun 3, 2020
Closed
@yceruto yceruto deleted the anonymous_lazy branch June 3, 2020 20:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yceruto @nicolas-grekas @stof