Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow-plugins in the skeleton config #201

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Conversation

stof
Copy link
Member

@stof stof commented Dec 8, 2021

Refs composer/composer#10314

For now, the default value in Composer is still to allow all plugins implicitly for BC. But the behavior will change in July 2022 to default to an empty list of allowed plugins.

This PR has 2 effects:

  • it makes new project use the new Composer behavior directly instead of relying on the BC layer
  • it marks symfony/flex as an allowed plugin, as our skeleton is meant to be used with Flex

The first point means that projects installing other composer plugins will need to mark them as allowed for them to run (but composer update running in an interactive shell will ask for that anyway)

@nicolas-grekas
Copy link
Member

We should also list symfony/runtime
This should target 4.4 don't you think?
As an additional step, we might want flex to generate these entries in existing projects.
Up for a PR doing so?

@stof
Copy link
Member Author

stof commented Dec 8, 2021

I'll change the target branch to be 4.4
And yeah, symfony/runtime should indeed also be whitelisted in 5.3+

As an additional step, we might want flex to generate these entries in existing projects.

not needed. Composer will ask interactively about that when running Composer 2.2+ in an existing project AFAICT.

@stof stof changed the base branch from 5.4 to 4.4 December 8, 2021 13:45
@stof
Copy link
Member Author

stof commented Dec 8, 2021

I'll send another PR for symfony/runtime once this PR is merged and merged up inside the 5.3 branch (or 5.4 if we don't update 5.3 anymore).

@nicolas-grekas
Copy link
Member

Thanks @stof
I'm going to add symfony/runtime while merging up, no worries.

@nicolas-grekas
Copy link
Member

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit fa3062f into symfony:4.4 Dec 11, 2021
nicolas-grekas added a commit to symfony/website-skeleton that referenced this pull request Dec 11, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

Add allow-plugins in the skeleton config

Same than symfony/skeleton#201

Commits
-------

8880ee0 Add allow-plugins in the skeleton config
@stof stof deleted the patch-1 branch July 7, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants