Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translator] Document intl format #10264

Closed
Nyholm opened this issue Sep 5, 2018 · 5 comments
Closed

[Translator] Document intl format #10264

Nyholm opened this issue Sep 5, 2018 · 5 comments
Milestone
4.2

Comments

@Nyholm
Copy link
Member

Nyholm commented Sep 5, 2018 •
edited

We should document how to use intl format.

See related PR: symfony/symfony#27399

Some description of the format here:
https://messageformat.github.io/messageformat/page-guide
@Nyholm Nyholm mentioned this issue Sep 5, 2018
Merged
@javiereguiluz
Copy link
Member

Thanks for opening this issue Tobias. Hopefully you'll find sometime to document this new feature yourself ... because I'm afraid I don't understand it well enough to document it. Thanks!

@javiereguiluz javiereguiluz added this to the 4.2 milestone Sep 7, 2018
@Nyholm
Copy link
Member Author

Nyholm commented Sep 7, 2018

Yes. That is the plan. But in case I forget or are too slow I thought it would be a good thing to write it down.

I'll write on this issue when I begin with this feature.
Anyone: feel free to start and we'll complete it together.

fabpot added a commit to symfony/symfony that referenced this issue Oct 6, 2018
@fabpot
feature #28375 [Translator] Deprecated transChoice and moved it away …
23b0787 
…from contracts (Nyholm, nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Translator] Deprecated transChoice and moved it away from contracts

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | Issue: symfony/symfony-docs#10264

This will address comment made here: #27399 (review)

This PR moves the `transChoice()` method away from Contracts and back to the component. I also reverted changes in the `IdentityTranslator`. I will still use the deprecated `MessageSelector` but this is not fine since `transChoice()` is also deprecated.

Commits
-------

dc5f3bf Make trans + %count% parameter resolve plurals
d870a85 [Translator] Deprecated transChoice and moved it away from contracts
@nicolas-grekas
Copy link
Member

A nice intl+icu fiddle we could link in the doc!
https://format-message.github.io/icu-message-format-for-translators/

@nicolas-grekas
Copy link
Member

Should also tell about symfony/symfony#28952

@nicolas-grekas nicolas-grekas mentioned this issue Feb 24, 2019
Closed
@javiereguiluz
Copy link
Member

Fixed by the great #11523 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
3 participants
@javiereguiluz @nicolas-grekas @Nyholm