Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Update .env for "send grid" recipe change #12630

Closed
weaverryan opened this issue Nov 12, 2019 · 0 comments
Closed

[Mailer] Update .env for "send grid" recipe change #12630

weaverryan opened this issue Nov 12, 2019 · 0 comments
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) Mailer
Milestone
4.4

Comments

@weaverryan
Copy link
Member

In https://symfony.com/doc/4.4/mailer.html#using-a-3rd-party-transport

It says the .env file will look like this after installing sendgrid transport:

# .env
SENDGRID_KEY=
MAILER_DSN=sendgrid://$SENDGRID_KEY@default

(and that you only need to then configure SENDGRID_KEY). That's not true anymore. The recipe no longer uses 2 env variables: https://github.com/symfony/recipes/blob/master/symfony/sendgrid-mailer/4.4/manifest.json
@weaverryan weaverryan added this to the 4.4 milestone Nov 12, 2019
@wouterj wouterj added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label Nov 22, 2019
@ThomasBerends ThomasBerends mentioned this issue Nov 23, 2019
Merged
wouterj pushed a commit to ThomasBerends/symfony-docs that referenced this issue Nov 23, 2019
@wouterj
symfony#12630 Update .env for \"send grid\" recipe change
3dfe2d6
wouterj added a commit that referenced this issue Nov 23, 2019
@wouterj
Merge branch '4.4' into 5.0
9675880 
* 4.4:
  #12630 Update .env for \"send grid\" recipe change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required) Mailer
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@weaverryan @wouterj @OskarStark