Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a tiny article about CSRF #8868

Closed
javiereguiluz opened this issue Dec 10, 2017 · 2 comments
Closed

Remove a tiny article about CSRF #8868

javiereguiluz opened this issue Dec 10, 2017 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@javiereguiluz
Copy link
Member

This article is tiny: http://symfony.com/doc/current/controller/csrf_token_validation.html and we're removing those kind of articles and merging them into longer articles to make things easier to maintain.

Not to contributors: please don't send a pull request to fix this. First we must decide if we want to merge all CSRF related contents in a new article and where to put it. Thanks!

@weaverryan
Copy link
Member

👍 for re-thinking this. From what I can see, we have the following CSRF info:

I think we should create one new article "CSRF Protection" under the security/ section. This would include all of this content so the user can learn how to use it in forms, without forms, and on the login page. We can then link to this article from the form, security & controller sections. I like it in its own article because it is an important topic.

Also, in MakerBundle, we when we add a "login form authenticator" maker, we can auto-generate code that includes CSRF protection. We should make CSRF protection as automatic as possible so that users don't need to think about it much (the form implementation is pretty perfect in that way).

@javiereguiluz
Copy link
Member Author

I like this. I'm preparing a pull request to see how this works in practice. Thanks!

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 12, 2017
weaverryan added a commit that referenced this issue Dec 28, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8873).

Discussion
----------

Refactored the CSRF docs

This fixes #8868.

Commits
-------

5300c20 Fixed a grammar error
ec3f769 Fixed another reference
9173ac9 Fixed some internal references
187c836 Refactored the CSRF docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

3 participants