Update custom_constraint.rst #10671
Closed
Update custom_constraint.rst #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,10 @@ The validator class is also simple, and only has one required method ``validate( | |||
| { | |||
| public function validate($value, Constraint $constraint) | |||
| { | |||
| if (!$constraint instanceof ContainsAlphanumeric) { | |||
There was a problem hiding this comment.
maybe \assert($constraint instanceof ContainsAlphanumeric) would be a better fit here?
There was a problem hiding this comment.
This is inline with how all core validators are implemented.
xabbuh
approved these changes
Nov 14, 2018
|
Thanks Thomas. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 14, 2018
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #10671). Discussion ---------- Update custom_constraint.rst Just added the constraint check to limit the `ContainsAlphanumericValidator` use with the `ContainsAlphanumeric` constraint. Commits ------- bb30126 Update custom_constraint.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added the constraint check to limit the
ContainsAlphanumericValidatoruse with theContainsAlphanumericconstraint.