Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encore (advanced): add documentation for configureLoaderRule() method #11075

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Encore (advanced): add documentation for configureLoaderRule() method #11075

merged 3 commits into from
Mar 25, 2019

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Mar 1, 2019

Hey,

This PR add a new entry in the advanced configuration of Webpack Encore, which explains how to use the new method configureLoaderRule().

Ref: symfony/webpack-encore#509

Copy link
Contributor

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (really minor) suggestions :)

frontend/encore/advanced-config.rst Outdated Show resolved Hide resolved
frontend/encore/advanced-config.rst Outdated Show resolved Hide resolved
frontend/encore/advanced-config.rst Outdated Show resolved Hide resolved
frontend/encore/advanced-config.rst Outdated Show resolved Hide resolved
frontend/encore/advanced-config.rst Outdated Show resolved Hide resolved
Co-Authored-By: Kocal <kocal@live.fr>
@Kocal
Copy link
Contributor Author

Kocal commented Mar 6, 2019

Thanks, that's better like this! :)

@weaverryan
Copy link
Member

Thank you @Kocal!

@weaverryan weaverryan merged commit e3d43b9 into symfony:3.4 Mar 25, 2019
weaverryan added a commit that referenced this pull request Mar 25, 2019
…derRule()` method (Kocal, Lyrkan, weaverryan)

This PR was merged into the 3.4 branch.

Discussion
----------

Encore (advanced): add documentation for `configureLoaderRule()` method

Hey,

This PR add a new entry in the advanced configuration of Webpack Encore, which explains how to use the new method `configureLoaderRule()`.

Ref: symfony/webpack-encore#509

Commits
-------

e3d43b9 minor tweak
71fd3b7 Apply suggestions from code review
c02322c Encore (advanced): add documentation for `configureLoaderRule()` method
@Kocal Kocal deleted the encore/configure-loader-rule branch March 26, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants