Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monolog] Added documentation about ElasticsearchLogstashHandler #12201

Merged
merged 1 commit into from Sep 18, 2019
Merged

[Monolog] Added documentation about ElasticsearchLogstashHandler #12201

merged 1 commit into from Sep 18, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 19, 2019 •
edited

Fixes #12198

OskarStark
OskarStark reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Greg 👍

I left some comments.

logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
@OskarStark OskarStark added this to the 4.4 milestone Aug 19, 2019
@lyrixx
Copy link
Member Author

lyrixx commented Aug 19, 2019

@OskarStark Thanks for the review. I updated the PR

OskarStark
OskarStark reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round 😄

logging/handlers.rst Show resolved Hide resolved
logging/handlers.rst Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Show resolved Hide resolved
logging/handlers.rst Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
@lyrixx
Copy link
Member Author

lyrixx commented Aug 19, 2019

Second "thanks" :)

@lyrixx
Copy link
Member Author

lyrixx commented Sep 9, 2019 •
edited

Could we merge this one?

@OskarStark
Copy link
Contributor

@javiereguiluz could you please give us a final review here? Thanks 🙏

javiereguiluz
javiereguiluz approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor comments. Nice work! Thanks.

logging/handlers.rst Outdated Show resolved Hide resolved
logging/handlers.rst Outdated Show resolved Hide resolved
@OskarStark
Copy link
Contributor

Please check the warnings by DOCtor-RST

@lyrixx lyrixx requested a review from xabbuh as a code owner September 10, 2019 13:14
@javiereguiluz
Copy link
Member

Grégoire, thanks for providing these docs!

javiereguiluz added a commit that referenced this pull request Sep 18, 2019
@javiereguiluz
minor #12201 [Monolog] Added documentation about ElasticsearchLogstas…
d2ae20d 
…hHandler (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[Monolog] Added documentation about ElasticsearchLogstashHandler

Fixes #12198

Commits
-------

0842526 [Monolog] Added documentation about ElasticsearchLogstashHandler
@javiereguiluz javiereguiluz merged commit 0842526 into symfony:4.4 Sep 18, 2019
@lyrixx lyrixx deleted the monolog-es branch September 18, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Logger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lyrixx @OskarStark @javiereguiluz @carsonbot