[Mailer] add ability to disable the TLS peer verification via DSN #12997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 29, 2020
…ion via DSN (Aurélien Fontaine) This PR was squashed before being merged into the 5.1-dev branch (closes #35262). Discussion ---------- [Mailer] add ability to disable the TLS peer verification via DSN | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix | License | MIT | Doc PR | symfony/symfony-docs/pull/12997 Add the ability to disable the peer TLS verification with the DNS when using `EsmtpTransport` like this : ``` MAILER_DSN=smtp://foo@default?verify_peer=false ``` By default the verification is enabled Commits ------- 4b854da [Mailer] add ability to disable the TLS peer verification via DSN
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Jan 29, 2020
…ion via DSN (Aurélien Fontaine) This PR was squashed before being merged into the 5.1-dev branch (closes #35262). Discussion ---------- [Mailer] add ability to disable the TLS peer verification via DSN | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix | License | MIT | Doc PR | symfony/symfony-docs/pull/12997 Add the ability to disable the peer TLS verification with the DNS when using `EsmtpTransport` like this : ``` MAILER_DSN=smtp://foo@default?verify_peer=false ``` By default the verification is enabled Commits ------- 4b854da73e [Mailer] add ability to disable the TLS peer verification via DSN
Nyholm
suggested changes
Jan 29, 2020
There was a problem hiding this comment.
like if the SMTP server has a self signed certificate
You should still verify it. But if you are lazy like I am, then you are most likely to ignore it with this new settings =).
I think this should be rephrased.
I agree that this should be a separate paragraph, because many SMTP related transports extends from EstmpTransport which brings this feature.
Nyholm
suggested changes
Jan 29, 2020
OskarStark
added
Waiting Code Merge
javiereguiluz
force-pushed
the
new-mailer-feature
branch
from
0943b8b
to
28a391a
Compare
|
@Livda thanks for this contribution (and for contributing the feature too). We did some rewords while merging and added the missing Congrats on your first Symfony Docs contribution! |
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Sep 28, 2021
…ion via DSN (Aurélien Fontaine) This PR was squashed before being merged into the 5.1-dev branch (closes #35262). Discussion ---------- [Mailer] add ability to disable the TLS peer verification via DSN | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix | License | MIT | Doc PR | symfony/symfony-docs/pull/12997 Add the ability to disable the peer TLS verification with the DNS when using `EsmtpTransport` like this : ``` MAILER_DSN=smtp://foo@default?verify_peer=false ``` By default the verification is enabled Commits ------- 4b854da73e [Mailer] add ability to disable the TLS peer verification via DSN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the PR symfony/symfony#35262