Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] Added Notifier guide #13025

Merged
merged 6 commits into from
Feb 6, 2020
Merged

[Notifier] Added Notifier guide #13025

merged 6 commits into from
Feb 6, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Feb 2, 2020

This PR merges the work of our doc hero's @TheGarious, @andreybolonin and @savvasal in #12678, #12846 and #12963 .

Fixes #12430 and fixes #12552

The component has 2 different usages: Using the high-level Notifier abstraction and using the lower-level Chatter and Texter abstractions. I decided to only document the high-lever in the main guide and use sub guides for Chatter and Texter.

This PR focuses on having the base documentation ready. Some features (monolog & messenger integration) are not documented. Let's create issues for those and do them after this PR is merged.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small review from phone 📱

Great works so far 👍🏻👍🏻

notifier.rst Outdated Show resolved Hide resolved
notifier.rst Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier/chatters.rst Outdated Show resolved Hide resolved
notifier/chatters.rst Outdated Show resolved Hide resolved
@wouterj
Copy link
Member Author

wouterj commented Feb 2, 2020

Thanks for your quick review @OskarStark! And sorry for the number of spelling errors, I rushed this PR a bit :)

@OskarStark
Copy link
Contributor

No problem, glad you find time to make this first big step 👍🏻

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouter, thanks a lot for taking care of merging all contributed docs about this topic and for creating these initial docs. They are great!

notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
notifier.rst Outdated Show resolved Hide resolved
components/notifier.rst Show resolved Hide resolved
wouterj and others added 2 commits February 5, 2020 21:32
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier
guide.
Co-Authored-By: Savvas Alexandrou <savvas.alexandrou@gmail.com>
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, let’s merge this state 👍🏻

@OskarStark
Copy link
Contributor

Amazing work. Thanks to all contributors 👍 🎉

OskarStark added a commit that referenced this pull request Feb 6, 2020
…onin, savvasal, wouterj)

This PR was merged into the 5.0 branch.

Discussion
----------

[Notifier] Added Notifier guide

This PR merges the work of our doc hero's @TheGarious, @andreybolonin and @savvasal in #12678, #12846 and #12963 .

Fixes #12430 and fixes #12552

The component has 2 different usages: Using the high-level Notifier abstraction and using the lower-level Chatter and Texter abstractions. I decided to only document the high-lever in the main guide and use sub guides for Chatter and Texter.

This PR focuses on having the base documentation ready. Some features (monolog & messenger integration) are not documented. Let's create issues for those and do them after this PR is merged.

Commits
-------

69f3330 Improved some grammar thanks to @savvasal
06f7009 Add Notifier component documentation
0179303 Reorder the use statements alphabetically
b9d0d7f Slack notifier actions documentation
34f23d0 add notifier.rst
4810fbf WIP Notifer Page
@OskarStark OskarStark merged commit 69f3330 into symfony:5.0 Feb 6, 2020
@wouterj wouterj deleted the pull-12678 branch February 6, 2020 09:20
Nexmo ``symfony/nexmo-notifier`` ``nexmo://KEY:SECRET@default?from=FROM``
======= =========================== ========================================

To enable a texter, add the add the correct DSN in your ``.env`` file and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: add the is doubled :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest PR ✌🏻 Thanks for the hint

fabpot added a commit to symfony/symfony that referenced this pull request Apr 21, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Notifier] Add Free Mobile notifier

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Implements symfony/symfony-docs#13025 (review)
| License       | MIT
| Doc PR        | Will document if accepted (see **Usage** below)

## Add a new notifier (SMS) with the French Free Mobile provider.

It is a **special notifier** as it **only send the SMS to the self user**,
but I think it can be **useful for notification alerting purposes** (the way I use it already, and plan to use it with the component)

---

**Provider doc:** (🇫🇷 sorry)

https://mobile.free.fr/moncompte/index.php?page=options

<img width="716" alt="1" src="https://user-images.githubusercontent.com/13205768/74357784-b55c3500-4dc0-11ea-95ba-19ded062e800.png">

<img width="431" alt="2" src="https://user-images.githubusercontent.com/13205768/74357786-b7be8f00-4dc0-11ea-837e-b922c20e9a2e.png">

---

**Usage:**

```
// .env file
FREEMOBILE_DSN=freemobile://LOGIN:PASSWORD@default?phone=PHONE
```

where:
 - `LOGIN` is your Free Mobile login
 - `PASSWORD` is the token displayed in the config panel
- `PHONE` is your Free Mobile phone number

```yaml
// config/packages/notifiers.yaml file
framework:
    notifier:
        texter_transports:
            freemobile: '%env(FREEMOBILE_DSN)%'
```

Then you can then use it like documented here https://symfony.com/doc/current/notifier/texters.html

ℹ️ As this is a special notifier, the `PHONE` provided inside the DSN mut be the same used [here](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Notifier/Message/SmsMessage.php#L31) for `$phone` value

---

Voilà!

Commits
-------

1b8709e Add Free Mobile notifier
symfony-splitter pushed a commit to symfony/notifier that referenced this pull request Apr 21, 2020
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Notifier] Add Free Mobile notifier

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Implements symfony/symfony-docs#13025 (review)
| License       | MIT
| Doc PR        | Will document if accepted (see **Usage** below)

## Add a new notifier (SMS) with the French Free Mobile provider.

It is a **special notifier** as it **only send the SMS to the self user**,
but I think it can be **useful for notification alerting purposes** (the way I use it already, and plan to use it with the component)

---

**Provider doc:** (🇫🇷 sorry)

https://mobile.free.fr/moncompte/index.php?page=options

<img width="716" alt="1" src="https://user-images.githubusercontent.com/13205768/74357784-b55c3500-4dc0-11ea-95ba-19ded062e800.png">

<img width="431" alt="2" src="https://user-images.githubusercontent.com/13205768/74357786-b7be8f00-4dc0-11ea-837e-b922c20e9a2e.png">

---

**Usage:**

```
// .env file
FREEMOBILE_DSN=freemobile://LOGIN:PASSWORD@default?phone=PHONE
```

where:
 - `LOGIN` is your Free Mobile login
 - `PASSWORD` is the token displayed in the config panel
- `PHONE` is your Free Mobile phone number

```yaml
// config/packages/notifiers.yaml file
framework:
    notifier:
        texter_transports:
            freemobile: '%env(FREEMOBILE_DSN)%'
```

Then you can then use it like documented here https://symfony.com/doc/current/notifier/texters.html

ℹ️ As this is a special notifier, the `PHONE` provided inside the DSN mut be the same used [here](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Notifier/Message/SmsMessage.php#L31) for `$phone` value

---

Voilà!

Commits
-------

1b8709ee72 Add Free Mobile notifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants