Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name modified post merge #14057

Merged

Conversation

noniagriconomie
Copy link
Contributor

@noniagriconomie noniagriconomie commented Aug 12, 2020

hi, small fix related to symfony/symfony@a89a2a8
Linked to symfony/symfony#37809

thx !

fabpot added a commit to symfony/symfony that referenced this pull request Aug 12, 2020
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Notifier] add doc for free mobile dsn

| Q             | A
| ------------- | ---
| Branch?       | master (maybe 5.1 ? it is only code doc)
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony/symfony-docs#13600 (comment)
| License       | MIT
| Doc PR        |

Improve readme according to the linked comment
I've taken info of my original PR #35690 (with some rewrite)

Also the package was renamed, fixing the doc here symfony/symfony-docs#14057

Commits
-------

eb067ed [Notifier] add doc for free mobile dsn
@xabbuh xabbuh added this to the 5.1 milestone Aug 21, 2020
@xabbuh xabbuh changed the base branch from master to 5.1 August 21, 2020 14:49
@xabbuh xabbuh requested a review from HeahDude as a code owner August 21, 2020 14:49
@xabbuh xabbuh force-pushed the feature-free-mobile-notifier-doc branch from da42fd5 to 0bf5920 Compare August 21, 2020 14:49
@xabbuh
Copy link
Member

xabbuh commented Aug 21, 2020

Thank you @noniagriconomie.

@xabbuh xabbuh merged commit 5203e78 into symfony:5.1 Aug 21, 2020
@noniagriconomie noniagriconomie deleted the feature-free-mobile-notifier-doc branch August 21, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants