Create compound.rst.inc #2362 #3336
Conversation
dpcat237
commented
Dec 14, 2013
dpcat237
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
Create description for "compound" option.
|
@dpcat237 the template goes in the description top part |
|
|
||
| **type**: ``boolean`` | ||
|
|
||
| This option define that if form is compound. It's independent of whether the form actually has children. A form can be compound and have no children at all, like for example an empty collection form. |
There was a problem hiding this comment.
This option defines if form is compound.
|
maybe cut the line to 100 characters per line |
|
no, it must be wrapped after the first word that crosses the 72th character |
|
It doesn't make sense to only add this file. It is not included somewhere, you should include the option in the form types that makes sense. |
|
I'm sorry, it's one of my first pull request to this project and I didn't review pull request standards. I'll be more rigorous. |
|
And don't worry about the confusions. We really appreciate your contribution and are of course happy to help you finish your pull request. :) |
|
@wouterj do I have to add versionadded directive to this option too? |
|
@dpcat237 I don't think so, because it is there in all supported versions (it was added in 2.1) |
|
|
||
| **type**: ``boolean`` | ||
|
|
||
| This option define that if form is compound. It's independent of whether the |
There was a problem hiding this comment.
I think this should be a bit reworded:
This option specifies if a form is compound. This is independent of whether the form actually has children. A form can be compound but don't have any children at all (e.g. an empty collection form).
Sorry for the late suggestions.
|
Okay Ryan. Was pleasure help to community :) I'll try find time to be more involved in Symfony community ;) Regards |
