Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] add cautionary note on ini file loader limitation #3431

Conversation

cordoval
Copy link
Contributor

@cordoval cordoval commented Jan 6, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #2517
License CC-ASA 3.0 Unported

Sent using Gush

@@ -12,6 +12,13 @@ The Config component provides several classes to help you find, load, combine,
autofill and validate configuration values of any kind, whatever their source
may be (YAML, XML, INI files, or for instance a database).

.. caution::

``IniFileLoader`` parses with the `parse_ini_file` function, therefore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IniFileLoader [...]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:phpfunction:`parse_ini_file`

@cordoval
Copy link
Contributor Author

done @wouterj @weaverryan, i am learning lots of formatting in rst with your help, thanks, also the good english!

@@ -12,6 +12,13 @@ The Config component provides several classes to help you find, load, combine,
autofill and validate configuration values of any kind, whatever their source
may be (YAML, XML, INI files, or for instance a database).

.. caution::

The ``IniFileLoader`` parses with the :phpfunction:`parse_ini_file` function,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IniFileLoader parses the file contents using the :phpfunction:parse_ini_file function. Therefore, [...]

@weaverryan
Copy link
Member

Thanks Luis!

weaverryan added a commit that referenced this pull request Jan 21, 2014
…n (cordoval)

This PR was merged into the 2.3 branch.

Discussion
----------

[Config] add cautionary note on ini file loader limitation

| Q             | A                   |
| ---           | ---                 |
| Doc fix?      | yes                 |
| New docs?     | no                  |
| Applies to    | 2.3+                |
| Fixed tickets | #2517               |
| License       | CC-ASA 3.0 Unported |

 Sent using [Gush](https://github.com/cordoval/gush)

Commits
-------

4f02a8a address comments
dd3dd70 address comments, even the Boolean one
4436dae add warning for inifile loader
@weaverryan weaverryan merged commit 4f02a8a into symfony:2.3 Jan 21, 2014
@cordoval cordoval deleted the 2517-document-the-limitation-of-the-dependency-injection-ini-loader branch January 21, 2014 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants