Fix Image constraint class and validator link #3646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Image constraint links from File and FileValidator to Image and ImageValidator.
|
👍 |
|
This looks good, but @jbafford can you open a new PR against 2.3? That's the earliest supported branch, and it looks like trying to patch this into 2.3 cause a conflict. Thanks! |
|
I think the difference is minor formatting changes, but sure, I'll open a new PR against a newer version later today. |
|
Yea, I'm sure it is - but I use a utility to merge in that also tracks a lot of extra metadata about the PR, but it doesn't (yet) have the super-power to switch branches and fix conflicts. So, I appreciate it in advance :) |
|
Ping @jbafford! No rush, just bothering you :) |
weaverryan
added a commit
that referenced
this pull request
Apr 2, 2014
|
Rebased and merged over at #3747. Thanks John (and no worries about not rebasing)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Image constraint links from File and FileValidator to Image and ImageValidator.