Email message instantiation changed to a more 'symfonysh' way. #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks a lot @alebo. It sure is a lot better now! |
wouterj
added a commit
that referenced
this pull request
Jan 16, 2015
… way. (alebo) This PR was merged into the 2.3 branch. Discussion ---------- Email message instantiation changed to a more 'symfonysh' way. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | I believe that using a static factory method for instantiation isn't the best way to do it in Symfony. So I suggest updating the Sending Emails example. Commits ------- 7f8b051 Changed email message instantiation to a more 'symfonysh' way.
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
May 7, 2015
wouterj
added a commit
that referenced
this pull request
May 10, 2015
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that using a static factory method for instantiation isn't the best way to do it in Symfony. So I suggest updating the Sending Emails example.