Add dateinterval type reference #4817

MisatoTremor · 2015-01-13T10:42:13Z

Q	A
Doc fix?	no
New docs?	yes
Applies to	3.2
Fixed tickets	#4816

xabbuh · 2015-01-13T11:52:57Z

reference/forms/types/dateinterval.rst

+| with_seconds | ``Boolean`` | The value of the `with_seconds`_ option.                        |
+--------------+-------------+-----------------------------------------------------------------+
+| with_invert  | ``Boolean`` | The value of the `with_invert`_ option.                         |
+--------------+-------------+-----------------------------------------------------------------+


I would use the "simple" table syntax:

============== =========== ====================================== Variable Type Usage ============== =========== ====================================== ``widget`` ``mixed`` The value of the `widget`_ option. ``with_years`` ``boolean`` The value of the `with_years`_ option. and so on ============== =========== ======================================

MisatoTremor · 2015-01-14T09:49:31Z

Changed it like @javiereguiluz said.
I only swapped the two RFC duration strings, putting the shorter (and hopefully easier to understand) one in the intro text and the full example in the string input description.
Also fixed the sorting of the options list to match the other type docs.

…m type (MisatoTremor) This PR was merged into the 3.2-dev branch. Discussion ---------- [Form][FrameworkBundle][Bridge] Add a DateInterval form type | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13389 | License | MIT | Doc PR | symfony/symfony-docs#4817 Replaces #15030 Commits ------- f7669be [Form] Add a DateInterval form type Also add dateinterval widget to twig templates.

HeahDude · 2016-06-22T13:34:15Z

symfony/symfony#16809 (comment) is merged now, can a maintainer please remove "On hold" label?

@MisatoTremor What the status here?

MisatoTremor · 2016-06-22T14:33:48Z

@HeahDude
Updated for 3.2

xabbuh · 2016-06-23T10:44:57Z

reference/forms/types/dateinterval.rst

+| Options              | - `days`_                                                                         |
+|                      | - `placeholder`_                                                                  |
+|                      | - `hours`_                                                                        |
+|                      | - `input`_                                                                        |


looks like something went wrong here

Removed read_only field reference, build now runs successfully.

@xabbuh What do you mean with this line comment?

@MisatoTremor When I reviewed this earlier today the diff looked completely broken. Looks like this was related to my browser then or the issue disappeared with your push. So everything's fine here how. :)

wouterj · 2016-07-02T12:11:23Z

reference/forms/types/dateinterval.rst

+
+DateIntervalType Field Type
+===========================
+


missing a versionadded directive:

.. versionadded:: 3.2 The DateIntervalType field type was introduced in Symfony 3.2.

wouterj · 2016-07-02T12:11:48Z

👍 Thanks for writing the documentation for the feature @MisatoTremor!

status: reviewed

javiereguiluz · 2016-07-04T07:08:05Z

reference/forms/types/dateinterval.rst

+date interval. It can be rendered as a integer or text input or select tags.
+
+The underlying format of the data can be a ``DateInterval`` object,
+a `RFC 3339`_ duration string (e.g. ``P1DT12H``) or an array.


Are we sure we want to link to the RFC 3339? In that RFC you can read the following:

It looks like we should link instead to ISO 8601 standard: https://en.wikipedia.org/wiki/ISO_8601

javiereguiluz · 2016-07-04T07:51:47Z

@MisatoTremor thanks for adding this form type and for providing the docs too. Today we've highlighted it in the Symfony blog (see New in Symfony 3.2: DateInterval form type).

When writing the blog post, I wondered if this type could be a bit easier to use. In particular, I wonder if the input option could be removed. If it's only used to tell the form type which format we are using (DateInterval, array or string) I think we can detect the format automatically. Do you think that would be possible? Thanks!

MisatoTremor · 2016-07-04T10:22:16Z

@javiereguiluz Thanks for the nice highlight! :)

I've included the option according to other date/time types, but this indeed sounds like a great improvement. Maybe this could be done for the other types, too. Will look into into

weaverryan · 2016-07-10T16:06:48Z

reference/forms/types/dateinterval.rst

+options are ``input`` and ``widget``.
+
+Suppose that you have a ``remindEvery`` field whose underlying interval is a
+``DateInterval`` object. The following configures the ``dateinterval`` type


... configures the ``DateIntervalType``

weaverryan · 2016-07-10T16:37:13Z

Thanks for the work @MisatoTremor - it's a really interesting component! And I'm sorry, I just peppered you with comments :)

Status: Needs Work

MisatoTremor · 2016-07-29T16:23:47Z

@weaverryan Thank for your review Ryan. I applied all but one which I commented upon.

wouterj · 2016-11-08T12:04:21Z

Hi @MisatoTremor! I'm sorry for the long delay, seems like this one slipped under our radar. As 3 doc members already reviewed this and you fixed their comments, I assume this one is ready to merge.

/cc @symfony/team-symfony-docs

status: reviewed

javiereguiluz · 2016-11-08T14:51:15Z

👍 this is indeed ready to be merged. Thanks @MisatoTremor.

MisatoTremor · 2016-11-09T12:19:16Z

@wouterj I totally understand this. :) There's much to do and also more important sections. You all are doing a great job!

Thanks for the update.

wouterj · 2016-11-10T19:49:03Z

Thanks Steffen for your work & patience! This is now merged in the docs and will be online tomorrow.

This PR was merged into the master branch. Discussion ---------- Add dateinterval type reference | Q | A | | --- | --- | | Doc fix? | no | | New docs? | yes | | Applies to | 3.2 | | Fixed tickets | #4816 | Commits ------- 3d55585 Add dateinterval type reference

MisatoTremor mentioned this pull request Jan 13, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form type symfony/symfony#13390

Closed

xabbuh added Status: Needs Work On hold labels Jan 13, 2015

xabbuh reviewed Jan 13, 2015
View reviewed changes

MisatoTremor mentioned this pull request Jun 18, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form type symfony/symfony#15030

Closed

MisatoTremor mentioned this pull request Dec 2, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form type symfony/symfony#16809

Merged

xabbuh added this to the 3.2 milestone May 21, 2016

MisatoTremor force-pushed the add_dateinterval_doc branch from 32e42c2 to 1883265 Compare June 22, 2016 14:32

xabbuh removed the On hold label Jun 23, 2016

xabbuh changed the title ~~[WCM] Add dateinterval type reference~~ Add dateinterval type reference Jun 23, 2016

xabbuh reviewed Jun 23, 2016
View reviewed changes

MisatoTremor force-pushed the add_dateinterval_doc branch from 1883265 to f9128ee Compare June 23, 2016 15:30

wouterj reviewed Jul 2, 2016
View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jul 2, 2016

javiereguiluz reviewed Jul 4, 2016
View reviewed changes

MisatoTremor force-pushed the add_dateinterval_doc branch from f9128ee to 6ed9ed7 Compare July 4, 2016 10:18

weaverryan reviewed Jul 10, 2016
View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Jul 10, 2016

MisatoTremor force-pushed the add_dateinterval_doc branch from 6ed9ed7 to 2c5b539 Compare July 29, 2016 16:11

Add dateinterval type reference

3d55585

MisatoTremor force-pushed the add_dateinterval_doc branch from 2c5b539 to 3d55585 Compare July 29, 2016 16:15

carsonbot added Status: Reviewed and removed Status: Needs Work labels Nov 8, 2016

wouterj merged commit 3d55585 into symfony:master Nov 10, 2016

MisatoTremor deleted the add_dateinterval_doc branch November 22, 2016 09:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dateinterval type reference #4817

Add dateinterval type reference #4817

MisatoTremor commented Jan 13, 2015 •

edited

Loading

xabbuh Jan 13, 2015

MisatoTremor Jan 13, 2015

MisatoTremor commented Jan 14, 2015

HeahDude commented Jun 22, 2016

MisatoTremor commented Jun 22, 2016

xabbuh Jun 23, 2016

MisatoTremor Jun 23, 2016

xabbuh Jun 23, 2016

wouterj Jul 2, 2016

MisatoTremor Jul 4, 2016

wouterj commented Jul 2, 2016

javiereguiluz Jul 4, 2016

javiereguiluz commented Jul 4, 2016

MisatoTremor commented Jul 4, 2016

weaverryan Jul 10, 2016

weaverryan commented Jul 10, 2016

MisatoTremor commented Jul 29, 2016

wouterj commented Nov 8, 2016

javiereguiluz commented Nov 8, 2016

MisatoTremor commented Nov 9, 2016

wouterj commented Nov 10, 2016

Add dateinterval type reference #4817

Add dateinterval type reference #4817

Conversation

MisatoTremor commented Jan 13, 2015 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MisatoTremor commented Jan 14, 2015

HeahDude commented Jun 22, 2016

MisatoTremor commented Jun 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wouterj commented Jul 2, 2016

Choose a reason for hiding this comment

javiereguiluz commented Jul 4, 2016

MisatoTremor commented Jul 4, 2016

Choose a reason for hiding this comment

weaverryan commented Jul 10, 2016

MisatoTremor commented Jul 29, 2016

wouterj commented Nov 8, 2016

javiereguiluz commented Nov 8, 2016

MisatoTremor commented Nov 9, 2016

wouterj commented Nov 10, 2016

MisatoTremor commented Jan 13, 2015 •

edited

Loading