Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a note about the server_version DBAL option #5017

Merged
merged 1 commit into from
Mar 14, 2015
Merged

Added a note about the server_version DBAL option #5017

merged 1 commit into from
Mar 14, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets #4597

Some comments:

  • This is probably a temporary fix because DoctrineBundle will hopefully fix this problem soon
  • DBAL options are not explained, so I added this explanation as a note
  • If you agree with this, please merge this PR soon because people are having problems with this new option

@stof
Copy link
Member

stof commented Feb 21, 2015

note that server_version is not only a fix (configuring it explicitly avoids doing the version guessing for each request to your app).
And DoctrineBundle cannot fix the issue, because it does not come from DoctrineBundle (it comes from the fact that the ORM gets the database platform eagerly in many places, and so triggers the guessing even in cases it should not be needed)

@timglabisch
Copy link
Contributor

👍

@weaverryan weaverryan merged commit 470f713 into symfony:2.3 Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
@weaverryan
feature #5017 Added a note about the server_version DBAL option (javi…
1dbed80 
…ereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Added a note about the server_version DBAL option

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | #4597

Some comments:

  * This is probably a temporary fix because DoctrineBundle will hopefully fix this problem soon
  * DBAL options are not explained, so I added this explanation as a `note`
  * If you agree with this, please merge this PR soon because people are having problems with this new option

Commits
-------

470f713 Added a note about the server_version DBAL option
weaverryan added a commit that referenced this pull request Mar 14, 2015
@weaverryan
[#5017] Minor language tweaks
32b6228
@weaverryan
Copy link
Member

Looks great Javier! Yes, the issue is unfortunate, and hopefully we'll remedy it fully in the ORM soon (I actually can't repeat the error anymore).

Minor tweaks at sha: 32b6228

Thanks!

weaverryan added a commit that referenced this pull request Mar 14, 2015
@weaverryan
Merge branch '2.3' into 2.6
4166339 
* 2.3:
  [#5033] Tweaking variable name to "match" the service id
  [#5017] Minor language tweaks
  use definition list instead of table
  adding table for controller as a service
  Suggested ConEmu in addition to ANSICON to solve the Windows coloring limitation
  Minor rewording
  Reworded the note about Windows console and output coloring
  Update routing.rst
  Minor rewording
  add a note about apc for php recent versions
  Removed a wrong link to a included file
  Rewording
  Minor rewording
  Fixed an internal link
  Added a note about data transformers not being applied with inherit_data option set
  Added a commented config useful when you use symlinks
  Minor rewording
  Added a note about the class option of the services defined via factories
  Added a note about the server_version DBAL option

Conflicts:
	components/dependency_injection/factories.rst
weaverryan added a commit that referenced this pull request Mar 14, 2015
@weaverryan
Merge branch '2.6' into 2.7
5cae596 
* 2.6: (91 commits)
  [#5064] Minor language tweaks
  Fixing bad merge conflict (forgot to save!)
  Remove unnecessary component reference
  Correct RegisterListenersPass namespace
  Fix service id
  Switched the first example to a static constructor method
  added some more components for Tobion as a merger
  Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP
  [#5036] Typo fix (probably mine originally) caught by xabbuh
  reword to serves
  Adding a link to define "lts"
  Better wording
  Minor improvement for symfony-installer with LTS
  Updating for new security service names in 2.6
  [#5033] Tweaking variable name to "match" the service id
  [#5017] Minor language tweaks
  [#5015] Updating the security service name for 2.6 - thanks to Cordoval
  [#5015] Very small tweak
  [#5011] Adding one more fix I missed
  [#5011] Fixing minor build issue
  ...

Conflicts:
	book/security.rst
weaverryan added a commit that referenced this pull request Mar 14, 2015
@weaverryan
Merge branch '2.7'
f24c84f 
* 2.7: (103 commits)
  Backporting some stuff from 2.7, that I think must have gotten merged only there by accident
  [#5064] Minor language tweaks
  Fixing bad merge conflict (forgot to save!)
  Remove unnecessary component reference
  Correct RegisterListenersPass namespace
  Fix service id
  Switched the first example to a static constructor method
  added some more components for Tobion as a merger
  Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP
  [#5036] Typo fix (probably mine originally) caught by xabbuh
  reword to serves
  Adding a link to define "lts"
  Better wording
  Minor improvement for symfony-installer with LTS
  Updating for new security service names in 2.6
  [#5033] Tweaking variable name to "match" the service id
  [#5017] Minor language tweaks
  [#5015] Updating the security service name for 2.6 - thanks to Cordoval
  [#5015] Very small tweak
  [#5011] Adding one more fix I missed
  ...
@javiereguiluz javiereguiluz deleted the fix_4597 branch January 3, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@javiereguiluz @stof @timglabisch @weaverryan @wouterj