As per twigphp/Twig#472, automatic escaping is not yet available #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it would be a cool feature, it is also impossible to apply automatic escaping in most cases. Advertising this as a out-of-the-box feature is problematic, as it probably mislead multiple developers that are using the tool without applying proper contextual escaping.
|
Well, it is automatic in a way that it always escapes your variables unless you use the |
|
We should keep the mention of |
|
Then I got mislead by the wording. I'll reword it to fix my misconception. |
|
Thanks Marco! |
wouterj
added a commit
that referenced
this pull request
Mar 29, 2015
…ailable (Ocramius) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5121). Discussion ---------- As per twigphp/Twig#472, automatic escaping is not yet available While it would be a cool feature, it is also impossible to apply automatic escaping in most cases. Advertising this as a out-of-the-box feature is problematic, as it probably mislead multiple developers that are using the tool without applying proper contextual escaping. Ref: twigphp/Twig#472 Commits ------- 94a8655 As per twigphp/Twig#472, automatic escaping is not yet available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it would be a cool feature, it is also impossible to apply automatic escaping in most cases.
Advertising this as a out-of-the-box feature is problematic, as it probably mislead multiple developers
that are using the tool without applying proper contextual escaping.
Ref: twigphp/Twig#472