Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of *.class parameters from conventions #5229

Merged
merged 2 commits into from
May 16, 2015
Merged

Remove mention of *.class parameters from conventions #5229

merged 2 commits into from
May 16, 2015

Conversation

jvasseur
Copy link
Contributor

@jvasseur jvasseur commented May 5, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@stof
Copy link
Member

stof commented May 5, 2015

👍

@@ -167,9 +167,6 @@ Service Naming Conventions

* A group name uses the underscore notation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace the trailing semicolon with a dot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@xabbuh
Copy link
Member

xabbuh commented May 6, 2015

👍

@wouterj
Copy link
Member

wouterj commented May 16, 2015

Thanks for keeping the docs in sync with new decisions in Symfony world @jvasseur!

@wouterj wouterj merged commit b7721bc into symfony:2.3 May 16, 2015
wouterj added a commit that referenced this pull request May 16, 2015
…asseur)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove mention of *.class parameters from conventions

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

b7721bc Replace trailing semicolon
8a531eb Remove mention of *.class parameters from conventions
@jvasseur jvasseur deleted the class-parametres-removal branch May 18, 2015 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants