Update load_balancer_reverse_proxy.rst #5242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remind that the trusted_proxies setting needs to be removed or the setTrustedProxies method call will be overwritten.
| @@ -83,6 +83,9 @@ In this case, you'll need to - *very carefully* - trust *all* proxies. | |||
| $response = $kernel->handle($request); | |||
| // ... | |||
|
|
|||
| #. Ensure that the trusted_proxies setting in your app/config/config.yml is not set or | |||
There was a problem hiding this comment.
Can you please enclose the filename with double backticks?
|
@xabbuh - I've updated the formatting for this pr. |
| @@ -83,6 +83,9 @@ In this case, you'll need to - *very carefully* - trust *all* proxies. | |||
| $response = $kernel->handle($request); | |||
| // ... | |||
|
|
|||
| #. Ensure that the trusted_proxies setting in your ``app/config/config.yml`` is not set or | |||
| it will overwrite the ``setTrustedProxies`` call above. | |||
There was a problem hiding this comment.
Just one last comment: Can you please wrap lines after the first word that crosses the 72nd character?
|
I think this pull request is ready to be merged. Besides, it's a quick win and it can save users a fair amount of frustration when things go wrong. |
|
👍 |
|
Easy win indeed. Thanks Patrick! I've merged this into the 2.3 branch. |
weaverryan
added a commit
that referenced
this pull request
Jun 27, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5242). Discussion ---------- Update load_balancer_reverse_proxy.rst Remind that the trusted_proxies setting needs to be removed or the setTrustedProxies method call will be overwritten. Commits ------- da65156 Adjust line wrapping 4d8c89d Add formatting for file and method names 037eda8 Update load_balancer_reverse_proxy.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remind that the trusted_proxies setting needs to be removed or the setTrustedProxies method call will be overwritten.