Update Routes in the Getting Started documentation #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @routes in the "Actions and Controllers" and "Routes" sections of the Getting Started documentation are outdated it seems. I have just created a new project and it wasn't quite right. Of course you can still make sense of it but needs correcting.
|
Thanks for the perfect PR, @BT643. Congratz with your first Symfony contribution! :) |
wouterj
added a commit
that referenced
this pull request
May 16, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Update Routes in the Getting Started documentation The @routes in the "Actions and Controllers" and "Routes" sections of the Getting Started documentation are outdated it seems. I have just created a new project and it wasn't quite right. Of course you can still make sense of it but needs correcting. Commits ------- 7d52ec8 Update the_big_picture.rst b1e3b31 Update Routes in the Getting Started documentation
wouterj
added a commit
that referenced
this pull request
May 16, 2015
| @@ -219,7 +219,7 @@ the application homepage. The second value of ``@Route()`` (e.g. | |||
| ``name="homepage"``) is optional and sets the name of this route. For now | |||
| this name is not needed, but later it'll be useful for linking pages. | |||
|
|
|||
| Considering all this, the ``@Route("/", name="homepage")`` annotation creates | |||
| Considering all this, the ``@Route("/app/example", name="homepage")`` annotation creates | |||
| a new route called ``homepage`` which makes Symfony execute the ``index`` | |||
| action of the ``Default`` controller when the user browses the ``/`` path | |||
There was a problem hiding this comment.
this is not consistent anymore with the route definition
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @routes in the "Actions and Controllers" and "Routes" sections of the Getting Started documentation are outdated it seems.
I have just created a new project and it wasn't quite right. Of course you can still make sense of it but needs correcting.