Quick review of Form login chapter #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,7 +462,8 @@ firewall matches *all* URLs, including ``/login_check``). If ``/login_check`` | |||
| doesn't match any firewall, you'll receive a ``Unable to find the controller | |||
| for path "/login_check"`` exception. | |||
|
|
|||
| **4. Multiple firewalls don't share security context** | |||
| 4. Multiple Firewalls Don't share Security Context | |||
There was a problem hiding this comment.
this and (5) seem to not be related to form login, but just general security pitfalls.
wouterj
force-pushed
the
cb/security/form_login_setup-review
branch
from
95f996c
to
2cbd368
Compare
|
Thank you Wouter. |
xabbuh
added a commit
that referenced
this pull request
Jun 28, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Quick review of Form login chapter Commits ------- 2cbd368 Quick review of Form login chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.