Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated tree for front controller #5492

Closed
wants to merge 3 commits into from
Closed

updated tree for front controller #5492

wants to merge 3 commits into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

@xabbuh xabbuh mentioned this pull request Jul 6, 2015
Closed
javiereguiluz
javiereguiluz reviewed Jul 16, 2015
View reviewed changes
create_framework/front-controller.rst
@@ -146,11 +146,13 @@ web root directory:

example.com
├── composer.json
├── composer.lock
│ src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again this line should be:

├── src

Instead of:

│   src

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OskarStark
Copy link
Contributor Author

can we merge this @wouterj @xabbuh

@wouterj
Copy link
Member

wouterj commented Jul 23, 2015

Yes (will do it another time though, just stopped merging)

@OskarStark
Copy link
Contributor Author

(y) thank you @wouterj

@xabbuh
Copy link
Member

xabbuh commented Jul 23, 2015

Thank you Oskar.

xabbuh added a commit that referenced this pull request Jul 23, 2015
@xabbuh
minor #5492 updated tree for front controller (OskarStark)
3bb1a25 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5492).

Discussion
----------

updated tree for front controller

Commits
-------

65dca62 updated tree for front controller
@xabbuh xabbuh closed this Jul 23, 2015
@OskarStark
Copy link
Contributor Author

👍

@OskarStark OskarStark deleted the patch-4 branch June 17, 2019 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OskarStark @wouterj @xabbuh @javiereguiluz