Use symfony.com theme on Platform.sh builds

[wouterj]

Requires fabpot/sphinx-php#30 to be merged first.

[xabbuh]

Could we run this with the CodeBlock class from the Sphinx core until the related pull request is merged?

[GuGuss]

👍

[wouterj]

Let's try :)

[wouterj]

Deployment failed, is there any way to see why /cc @GuGuss ?

[GuGuss]

The exact error message is:

Extension error:
    Could not import extension symfonycom.sphinx (exception: No module named symfonycom.sphinx)
    make: *** [html] Error 1

  E: Unknown error in the toolstack: CalledProcessError: Command 'pip install git+https://github.com/fabpot/sphinx-php.git
  make html
  ' returned non-zero exit status 2

E: Error building the project: Unable to build project, aborting deployment.

@wouterj I'll add you as an administrator to the Platform.sh project so you can see build results directly.

[damz]

@wouterj You cannot put files in .platform and expect them to be available during the build process.

Platform.sh supports multiple applications in the same repository. The first step of the build process is to split the repository into multiple application trees, each application being defined as a folder containing a .platform.app.yaml, excluding any subfolder itself containing a .platform.app.yaml.

Technically, .platform/ is a global folder, it is not part of the tree of any of the applications that you have in your repository, so it will not be available during the build process of any application.

[wouterj]

So things seem to work now! Thanks for the detailed information @damz.

In case anyone wonders why some code blocks do have line numbers, without the customized codeblock from the sphinx-php package, line numbers are only shown when the :linenums: flag is passed. Quite a few code blocks have this flag.

[xabbuh]

Wow!!! Great work, Wouter! 🎆

[damz]

And that looks pretty awesome. 👍

[GuGuss]

Looking better and better 👍

[wouterj]

And now, the last remaining piece is also added: Numbered code block

@weaverryan this is ready to merge

[xabbuh]

For some reason this failed on platform.sh. Are you able to see the reason @wouterj?

[wouterj]

E: Error building the project: Error checking out submodule 1b7c4b794d75f7b0eb6749cadccc58f87e3158a0.

Not sure why it can't check out that commit...

[lyrixx]

Why do we need this submodule, as we download it via pip in the .platform.yml ?

[xabbuh]

I think we don't you use pip on Travis, do we?

[wouterj]

we used submodules for travis as I didn't know we could use pip. Let's switch everything to pip :)

[wouterj]

And everything really works now. Thanks for the help everyone!

[stof]

/_exts can be removed now.
It was here to avoid people submitting changes to the submodule reference by mistake, but we don't have anything here anymore

[weaverryan]

Wow wow wow! This looks amazing! Seriously - this is so cool :).

I'll happily merge this!