updated validation.rst #5608
Closed
updated validation.rst #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UPGRADE guide doesn't say anything about this change: https://github.com/symfony/symfony/blob/2.8/UPGRADE-2.8.md 😕 |
|
@javiereguiluz I'm not sure where this PR should be merged to, but FieldError class is not found in Symfony project anywhere. |
|
ping @webmozart |
|
This change is 100% correct and a left-over from way before Symfony 2.0.0: symfony/form@889a160 So big 👍 and thanks @issei-m for finding & fixing this very old issue. |
|
Thanks again @issei-m, I've now merged it into the docs in version 2.3 (the oldest, still maintained, version) and will merge it up the other versions from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this change is correct but FieldError was renamed to FormError, right?