Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fe80::1 #5784

Closed
wants to merge 1 commit into from
Closed

Add fe80::1 #5784

wants to merge 1 commit into from

Conversation

j-d
Copy link
Contributor

@j-d j-d commented Oct 13, 2015

@javiereguiluz
Copy link
Member

👍 I think it makes sense to be consistent here.

@OskarStark
Copy link
Contributor

👍

@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

For consistency, it makes sense to add it here to. However, what was the actual reason to add it to the front controller?

@j-d
Copy link
Contributor Author

j-d commented Oct 18, 2015

This was the original reason: symfony/symfony-standard@2c84405

@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

Thanks for providing the background here. This looks like a reasonable change then. 👍

xabbuh added a commit that referenced this pull request Oct 18, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5784).

Discussion
----------

Add fe80::1

Same reason as in https://github.com/symfony/symfony-standard/blob/2.8/web/app_dev.php#L15

Commits
-------

c5859da Add fe80::1
xabbuh added a commit that referenced this pull request Oct 18, 2015
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2015

Thanks for providing this update @j-d. I have merged this into the 2.3. Then realised that we need to make the same change for the other configuration formats and that we an example similar to the dev front controller from the standard edition. I made those tweaks in 0ea3491.

@xabbuh xabbuh closed this Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants