Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book: Update Service Container Documentation #5883

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Book: Update Service Container Documentation #5883

merged 1 commit into from
Nov 12, 2015

Conversation

zanbaldwin
Copy link
Member

Missing <services> XML element wrapper for the Tags section example.

Q A
Doc fix? yes
New docs? no
Applies to 2.3 onwards
Fixed tickets #5882

@OskarStark
Copy link
Contributor

Good catch 👍

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2015

That's good catch @zanderbaldwin. Though we always use four spaces to indent XML in code examples. Would you be able to update your changes to reflect that?

Missing <services> XML block wrapper for the Tags section example. Fixes #5882.
@zanbaldwin
Copy link
Member Author

Sure! Just pushed the changes now 😄

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2015

Good catch, thanks @zanderbaldwin.

@xabbuh xabbuh merged commit 30eb4fa into symfony:2.3 Nov 12, 2015
xabbuh added a commit that referenced this pull request Nov 12, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Book: Update Service Container Documentation

Missing `<services>` XML element wrapper for the **Tags** section example.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | `2.3` onwards
| Fixed tickets | #5882

Commits
-------

30eb4fa Book: Update Service Container Documentation
@zanbaldwin zanbaldwin deleted the 5882-missing-xml-wrapper-element branch October 4, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants